[1730] in Kerberos_V5_Development
Re: load_v4 fix
daemon@ATHENA.MIT.EDU (Theodore Y. Ts'o)
Mon Sep 9 11:12:58 1996
Date: Mon, 9 Sep 1996 11:12:43 -0400
From: "Theodore Y. Ts'o" <tytso@MIT.EDU>
To: eichin@kitten.gen.ma.us
Cc: krbcore@MIT.EDU, eichin@cygnus.com
In-Reply-To: Mark W. Eichin's message of 08 Sep 1996 01:32:38 -0400,
<xe1g24tpo5k.fsf@paycheck.kitten.gen.ma.us>
From: eichin@kitten.gen.ma.us (Mark W. Eichin)
Date: 08 Sep 1996 01:32:38 -0400
The analysis: kdb5_util main calls kadm5_get_config_params and stashes
the result in global_params. load_v4db copies global_params, sets the
dbname (* so it looks like the user set it! *) and clears
admin_dbname... so it gets set to a name derived from dbname, like the
function is documented to do. This is of course wrong.
This is detritus left over from Barry's conversion of kdb5_util UI from
an ss-based interface to command-line utility UI. It used to be that
dbname was set by the user on the ss command-line, and so that's what
the code was there from.
There may very well be more cruft like this that we'll want to clean up
after beta 7. For now, I've looked over your change, and it's pretty
clear that it's safe, so I've checked it in for this release.
- Ted
