[19360] in Kerberos_V5_Development
Re: nextincr in krb5int_dns_init too small
daemon@ATHENA.MIT.EDU (Greg Hudson)
Mon Feb 22 16:29:58 2016
To: Daniel Colascione <dancol@dancol.org>, krbdev@mit.edu
From: Greg Hudson <ghudson@mit.edu>
Message-ID: <56CB7DC8.9000608@mit.edu>
Date: Mon, 22 Feb 2016 16:29:44 -0500
MIME-Version: 1.0
In-Reply-To: <56C5BD2F.9030903@dancol.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: krbdev-bounces@mit.edu
On 02/18/2016 07:46 AM, Daniel Colascione wrote:
> krb5int_dns_init has a conventional malloc-and-realloc-until-it-fits
> loop, but inside the loop body, we're calling res_nsearch, which can do
> non-trivial work. It'd be better to increase the initial guess from 2048
> to something bigger; even 4k is a trivial amount of memory these days,
> and I'm getting 2786-byte responses.
I am preparing a pull request to update the buffer size to 4K. Am I
correct to asssume that these 2786-byte responses include DNSSEC signatures?
_______________________________________________
krbdev mailing list krbdev@mit.edu
https://mailman.mit.edu/mailman/listinfo/krbdev
