[19575] in Kerberos_V5_Development

home help back first fref pref prev next nref lref last post

Re: krb5 commit: Modernize UTF-8/UCS-2 conversion code

daemon@ATHENA.MIT.EDU (Stefan Metzmacher)
Mon Apr 17 15:25:00 2017

To: Robbie Harwood <rharwood@redhat.com>
From: Stefan Metzmacher <metze@samba.org>
Message-ID: <c294c45e-6d55-063c-be21-0316e07bf81c@samba.org>
Date: Mon, 17 Apr 2017 21:24:40 +0200
MIME-Version: 1.0
In-Reply-To: <201704171858.v3HIwVhW013893@drugstore.mit.edu>
Cc: krbdev@mit.edu
Content-Type: multipart/mixed; boundary="===============8081511443501601099=="
Errors-To: krbdev-bounces@mit.edu

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--===============8081511443501601099==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="Das6kue6TIpXhIQMWOLMerSEPkq1RXD3C"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--Das6kue6TIpXhIQMWOLMerSEPkq1RXD3C
Content-Type: multipart/mixed; boundary="9hnKNjFV7RX174VIovM1mwUu0C5dlXUs4";
	protected-headers="v1"
From: Stefan Metzmacher <metze@samba.org>
To: Robbie Harwood <rharwood@redhat.com>
Cc: krbdev@mit.edu
Message-ID: <c294c45e-6d55-063c-be21-0316e07bf81c@samba.org>
Subject: Re: krb5 commit: Modernize UTF-8/UCS-2 conversion code
References: <201704171858.v3HIwVhW013893@drugstore.mit.edu>
In-Reply-To: <201704171858.v3HIwVhW013893@drugstore.mit.edu>

--9hnKNjFV7RX174VIovM1mwUu0C5dlXUs4
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable

Hi Robbie,

is there a reson why you still limit this to USC-2 and not use full UTF16=

support?

We had a lot of trouble with the limited unicode support of krb5 librarie=
s
in Samba recently, see https://bugzilla.samba.org/show_bug.cgi?id=3D12262=


For now we worked arround it in Samba by limiting random machine password=
s
to unicode codepoints up to 0xffff.

metze

> https://github.com/krb5/krb5/commit/c4e8d444632140ecb47f31df133c0657f07=
f9be0
> commit c4e8d444632140ecb47f31df133c0657f07f9be0
> Author: Robbie Harwood <rharwood@redhat.com>
> Date:   Thu Apr 6 12:15:39 2017 -0400
>=20
>     Modernize UTF-8/UCS-2 conversion code
>    =20
>     Remove unused entry points as we only need to convert between
>     little-endian UCS-2 byte buffers and UTF-8.  Rename and simplify th=
e
>     remaining two function contracts.  Avoid pointer alignment and
>     endianness issues by operating on byte buffers and using store_16_l=
e()
>     and load_16_le().  Avoid two-pass operation using k5buf.
>    =20
>     [ghudson@mit.edu: simplified code using k5buf; simplified function
>     names and contracts; rewrote commit message]


--9hnKNjFV7RX174VIovM1mwUu0C5dlXUs4--

--Das6kue6TIpXhIQMWOLMerSEPkq1RXD3C
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)

iQIcBAEBAgAGBQJY9RZ9AAoJEA219WEoab1W3MkQAL8dVIo0Ga9lZYsvVXC2dSID
hlqCrPYP9uxul74MUH3ZbUM0Qvcxik1pbNj/LNES/imSbuqJW3nskJJYpwv1iP8/
P8QXpDCg6Afa1iSxpG2AxG2l4RgPo9aaX/H9N7lxUve96hQTNIzozz5df/pWcR/0
oQnglYhhgf4sC6IcWnELYq0lWg0oaRZ6vSVrXuvhU45iMyujORMom8fDVOq4Pm1+
4p+MZyhe1euZbNJmkjPK9IoBVFncE9iSmqJMxgPi17jvnJB7qawVBKkSf7MQLcEO
UFIyav52vdl38qug04RRmW69P5Wucnm4sF5lGfy21Iu6EWKIwRokHW1p1KOJejdS
nArtyabYqvNJqCMLpLE+af0VxPGhvTznHFJdS6gqAAdnUpZ/hR3nzRfUvQE/TPd1
MhfAFFeiSjpgt9oDFh6VemmBLROUMWmEvOBmSSSBGZbT6qNhWyViiXT0O+i90LI9
opOSgMFU9vP0+0j70ZC6trKU6MS8nTqLnU3FZXCZOrIqzpSndVzDV9z91FS6ePE8
tvJux6DHx/8hBnEC8kOcX2S6EJKkAjL2c/f4NbslnYDVvh/jxeHHaYdWFRCieVW9
DoLcrqeSaxYOFMd4bjT9AW4kDJSK0Wj6pkNYNJTa/lZfJCnpyDj6iCqC5hU3/Or3
m/Z7dtlQRkAe8JhNixcX
=uF9Z
-----END PGP SIGNATURE-----

--Das6kue6TIpXhIQMWOLMerSEPkq1RXD3C--

--===============8081511443501601099==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
krbdev mailing list             krbdev@mit.edu
https://mailman.mit.edu/mailman/listinfo/krbdev

--===============8081511443501601099==--

home help back first fref pref prev next nref lref last post