[19633] in Kerberos_V5_Development
RE:Change in include/k5-platform.h breaks compiling krb5 1.15.1 on
daemon@ATHENA.MIT.EDU (REIX, Tony)
Thu Aug 24 06:41:48 2017
From: "REIX, Tony" <tony.reix@atos.net>
To: Greg Hudson <ghudson@mit.edu>, "krbdev@mit.edu" <krbdev@mit.edu>
Date: Thu, 24 Aug 2017 10:41:32 +0000
Message-ID: <B37989F2852398498001550C29155BE5178BBCA2@FRCRPVV9EX3MSX.ww931.my-it-solutions.net>
In-Reply-To: <3d85ac04-8bde-5d64-9022-dbdaa764ab3e@mit.edu>
Content-Language: fr-FR
Content-Type: multipart/mixed;
boundary="_002_B37989F2852398498001550C29155BE5178BBCA2FRCRPVV9EX3MSXw_"
MIME-Version: 1.0
Errors-To: krbdev-bounces@mit.edu
--_002_B37989F2852398498001550C29155BE5178BBCA2FRCRPVV9EX3MSXw_
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Hummmm The patch does not apply correctly:=0A=
=0A=
+ patch -p1 -b --suffix .LHHd6fDW -s=0A=
+ 0< /opt/freeware/src/packages/SOURCES/krb5-1.15.1-LHHd6fDW.patch=0A=
1 out of 2 hunks FAILED -- saving rejects to file src/include/k5-platform.h=
.rej=0A=
Bad exit status from /var/opt/freeware/tmp/rpm-tmp.3088 (%prep)=0A=
=0A=
Did I something wrong ?=0A=
=0A=
Thx=0A=
=0A=
Tony=0A=
=0A=
=0A=
=0A=
# cat src/include/k5-platform.h.rej=0A=
***************=0A=
*** 361,376 ****=0A=
=0A=
=0A=
=0A=
- #if !defined(SHARED) && !defined(_WIN32)=0A=
- =0A=
- /*=0A=
- * In this case, we just don't care about finalization. The code will st=
ill=0A=
- * define the function, but we won't do anything with it.=0A=
- */=0A=
- # define MAKE_FINI_FUNCTION(NAME) \=0A=
- static void NAME(void) UNUSED=0A=
- =0A=
- #elif defined(USE_LINKER_FINI_OPTION) || defined(_WIN32)=0A=
/* If we're told the linker option will be used, it doesn't really=0A=
matter what compiler we're using. Do it the same way=0A=
regardless. */=0A=
--- 361,367 ----=0A=
=0A=
=0A=
=0A=
+ #if defined(USE_LINKER_FINI_OPTION) || defined(_WIN32)=0A=
/* If we're told the linker option will be used, it doesn't really=0A=
matter what compiler we're using. Do it the same way=0A=
regardless. */=0A=
=0A=
=0A=
Cordialement,=0A=
=0A=
Tony Reix=0A=
=0A=
Bull - ATOS=0A=
IBM Coop Architect & Technical Leader=0A=
Office : +33 (0) 4 76 29 72 67=0A=
1 rue de Provence - 38432 =C9chirolles - France=0A=
www.atos.net=0A=
=0A=
________________________________________=0A=
De : Greg Hudson [ghudson@mit.edu]=0A=
Envoy=E9 : jeudi 24 ao=FBt 2017 00:00=0A=
=C0 : REIX, Tony; krbdev@mit.edu=0A=
Objet : Re: Change in include/k5-platform.h breaks compiling krb5 1.15.1 on=
AIX (and more)=0A=
=0A=
On 08/23/2017 06:10 AM, REIX, Tony wrote:=0A=
> Linker error message on AIX is:=0A=
> ld: 0711-328 ERROR: Undefined initfini symbol: krb5int_thread_support_=
fini=0A=
> since the following code is generated, where krb5int_thread_support_fini(=
) is static:=0A=
=0A=
I think this problem affects platforms which set=0A=
use_linker_fini_option=3Dyes in shlib.conf but use SHOBJEXT=3D.o instead of=
=0A=
SHOBJEXT=3D.so, and therefore don't build the object files used in shared=
=0A=
libraries with -DSHARED. The affected platforms appear to be OSF/1,=0A=
IRIX (pre-6.3 and without gcc), and of course AIX.=0A=
=0A=
The offending commit is 4538146e1452e0966164119cefb0804993ce6bbb whose=0A=
goal was to disable finalizers in static libraries. We are really only=0A=
worried about that problem for __attribute__((destructor)) finalizers,=0A=
so it should be okay to effectively revert that commit in the=0A=
USE_LINKER_FINI_OPTION case, as the proposed patch does, because the=0A=
linker options are only applied when shared libraries are built. Rather=0A=
than add to the SHARED conditional, I prefer to reorder the clauses so=0A=
that the linker option stuff comes first, then the test for SHARED, then=0A=
the destructor attribute stuff.=0A=
=0A=
I filed a PR at https://github.com/krb5/krb5/pull/693 if you would like=0A=
to test what I expect to merge. I also put the diff up at=0A=
https://pastebin.com/LHHd6fDW (although I expect that to expire at some=0A=
point).=0A=
--_002_B37989F2852398498001550C29155BE5178BBCA2FRCRPVV9EX3MSXw_
Content-Type: text/x-patch; name="krb5-1.15.1-LHHd6fDW.patch"
Content-Description: krb5-1.15.1-LHHd6fDW.patch
Content-Disposition: attachment; filename="krb5-1.15.1-LHHd6fDW.patch";
size=3696; creation-date="Thu, 24 Aug 2017 10:40:52 GMT";
modification-date="Thu, 24 Aug 2017 10:40:52 GMT"
Content-Transfer-Encoding: base64
Y29tbWl0IDBlNGY3YTEyZDE0ZWI5M2ZhMzNlYTAzYjE4NTgyNDIyZjQ2OTI2NmIKQXV0aG9yOiBH
cmVnIEh1ZHNvbiA8Z2h1ZHNvbkBtaXQuZWR1PgpEYXRlOiAgIFdlZCBBdWcgMjMgMTc6NDU6MDIg
MjAxNyAtMDQwMAoKICAgIEZpeCBBSVggYnVpbGQgaXNzdWVzCiAgICAKICAgIEluIGs1LXBsYXRm
b3JtLmgsIG9ubHkgdGVzdCBmb3IgU0hBUkVEIGFuZCBkZWZpbmUgdGhlIGZpbmFsaXplciBhcwog
ICAgc3RhdGljIGlmIHdlIGRvbid0IGV4cGVjdCBsaW5rZXIgb3B0aW9ucyB0byBiZSB1c2VkIGZv
ciBmaW5hbGl6ZXJzLgogICAgU0hBUkVEIGlzIG5vdCBhIHJvYnVzdCB0ZXN0IChpdCBpc24ndCBk
ZWZpbmVkIHdoZW4gYnVpbGRpbmcgb2JqZWN0cwogICAgZm9yIHNoYXJlZCBsaWJyYXJpZXMgb24g
QUlYLCBPU0YvMSwgb3Igc29tZXRpbWVzIElSSVggYmVjYXVzZSB0aGV5CiAgICBkb24ndCB1c2Ug
c2VwYXJhdGUgUElDIG9iamVjdHMpLCBhbmQgYXMgbGlua2VyIGZpbmFsaXplciBvcHRpb25zIGFy
ZQogICAgb25seSBhcHBsaWVkIHdoZW4gc2hhcmVkIGxpYnJhcmllcyBhcmUgY3JlYXRlZCwgd2Ug
ZG9uJ3QgaGF2ZSB0byB3b3JyeQogICAgYWJvdXQgZmluYWxpemVycyBoYXBwZW5pbmcgZm9yIHN0
YXRpYyBsaWJyYXJpZXMuCiAgICAKICAgIEluIGV4cGFuZF9wYXRoLmMsIHJlbW92ZSB0aGUgdW5u
ZWNlc3Nhcnkgc3RydWN0dXJlIHRhZyBmcm9tICJzdHJ1Y3QKICAgIHRva2VuIiBhcyBpdCBjb25m
bGljdHMgd2l0aCA8bmV0L2lmX2FycC5oPiBvbiBBSVguCiAgICAKICAgIEluIGxvY2FsYWRkci5j
LCBpbml0aWFsaXplIG91dHB1dCBwYXJhbWV0ZXJzIGF0IHRoZSBiZWdpbm5pbmcgb2YKICAgIGdl
dF9pZnJlcV9hcnJheSgpLiAgT3RoZXJ3aXNlLCBnY2MgY2Fubm90IGJlIHN1cmUgdGhhdCB0aGV5
IGFyZSBhbHdheXMKICAgIHNldCB3aGVuIGdldF9pZnJlcV9hcnJheSgpIHJldHVybnMgMCwgYmVj
YXVzZSB3ZSB1c2UgZXJybm8gYXMgYSByZXR1cm4KICAgIHZhbHVlIGluIG9uZSBjYXNlLiAgQWxz
byByZW1vdmUgdHdvIHVudXNlZCB2YXJpYWJsZXMuCiAgICAKICAgIEJhc2VkIG9uIHBhdGNoZXMg
ZnJvbSBUb255IFJlaXguCiAgICAKICAgIHRpY2tldDogODYwOCAobmV3KQoKZGlmZiAtLWdpdCBh
L3NyYy9pbmNsdWRlL2s1LXBsYXRmb3JtLmggYi9zcmMvaW5jbHVkZS9rNS1wbGF0Zm9ybS5oCmlu
ZGV4IGQ1ODcxMGIuLjU0OGMwNDggMTAwNjQ0Ci0tLSBhL3NyYy9pbmNsdWRlL2s1LXBsYXRmb3Jt
LmgKKysrIGIvc3JjL2luY2x1ZGUvazUtcGxhdGZvcm0uaApAQCAtMzYxLDE2ICszNjEsNyBAQCB0
eXBlZGVmIHN0cnVjdCB7IGludCBlcnJvcjsgdW5zaWduZWQgY2hhciBkaWRfcnVuOyB9IGs1X2lu
aXRfdDsKIAogCiAKLSNpZiAhZGVmaW5lZChTSEFSRUQpICYmICFkZWZpbmVkKF9XSU4zMikKLQot
LyoKLSAqIEluIHRoaXMgY2FzZSwgd2UganVzdCBkb24ndCBjYXJlIGFib3V0IGZpbmFsaXphdGlv
bi4gIFRoZSBjb2RlIHdpbGwgc3RpbGwKLSAqIGRlZmluZSB0aGUgZnVuY3Rpb24sIGJ1dCB3ZSB3
b24ndCBkbyBhbnl0aGluZyB3aXRoIGl0LgotICovCi0jIGRlZmluZSBNQUtFX0ZJTklfRlVOQ1RJ
T04oTkFNRSkgICAgICAgICAgICAgICBcCi0gICAgICAgIHN0YXRpYyB2b2lkIE5BTUUodm9pZCkg
VU5VU0VECi0KLSNlbGlmIGRlZmluZWQoVVNFX0xJTktFUl9GSU5JX09QVElPTikgfHwgZGVmaW5l
ZChfV0lOMzIpCisjaWYgZGVmaW5lZChVU0VfTElOS0VSX0ZJTklfT1BUSU9OKSB8fCBkZWZpbmVk
KF9XSU4zMikKIC8qIElmIHdlJ3JlIHRvbGQgdGhlIGxpbmtlciBvcHRpb24gd2lsbCBiZSB1c2Vk
LCBpdCBkb2Vzbid0IHJlYWxseQogICAgbWF0dGVyIHdoYXQgY29tcGlsZXIgd2UncmUgdXNpbmcu
ICBEbyBpdCB0aGUgc2FtZSB3YXkKICAgIHJlZ2FyZGxlc3MuICAqLwpAQCAtNDA0LDYgKzM5NSwx
NSBAQCB0eXBlZGVmIHN0cnVjdCB7IGludCBlcnJvcjsgdW5zaWduZWQgY2hhciBkaWRfcnVuOyB9
IGs1X2luaXRfdDsKIAogIyBlbmRpZgogCisjZWxpZiAhZGVmaW5lZChTSEFSRUQpCisKKy8qCisg
KiBJbiB0aGlzIGNhc2UsIHdlIGp1c3QgZG9uJ3QgY2FyZSBhYm91dCBmaW5hbGl6YXRpb24uICBU
aGUgY29kZSB3aWxsIHN0aWxsCisgKiBkZWZpbmUgdGhlIGZ1bmN0aW9uLCBidXQgd2Ugd29uJ3Qg
ZG8gYW55dGhpbmcgd2l0aCBpdC4KKyAqLworIyBkZWZpbmUgTUFLRV9GSU5JX0ZVTkNUSU9OKE5B
TUUpICAgICAgICAgICAgICAgXAorICAgICAgICBzdGF0aWMgdm9pZCBOQU1FKHZvaWQpIFVOVVNF
RAorCiAjZWxpZiBkZWZpbmVkKF9fR05VQ19fKSAmJiBkZWZpbmVkKERFU1RSVUNUT1JfQVRUUl9X
T1JLUykKIC8qIElmIHdlJ3JlIHVzaW5nIGdjYywgaWYgdGhlIEMrKyBzdXBwb3J0IHdvcmtzLCB0
aGUgY29tcGlsZXIgc2hvdWxkCiAgICBidWlsZCBleGVjdXRhYmxlcyBhbmQgc2hhcmVkIGxpYnJh
cmllcyB0aGF0IHN1cHBvcnQgdGhlIHVzZSBvZgpkaWZmIC0tZ2l0IGEvc3JjL2xpYi9rcmI1L29z
L2V4cGFuZF9wYXRoLmMgYi9zcmMvbGliL2tyYjUvb3MvZXhwYW5kX3BhdGguYwppbmRleCBhOGEx
NGY0Li42MWZiMjM0IDEwMDY0NAotLS0gYS9zcmMvbGliL2tyYjUvb3MvZXhwYW5kX3BhdGguYwor
KysgYi9zcmMvbGliL2tyYjUvb3MvZXhwYW5kX3BhdGguYwpAQCAtMzUxLDcgKzM1MSw3IEBAIGV4
cGFuZF9udWxsKGtyYjVfY29udGV4dCBjb250ZXh0LCBQVFlQRSBwYXJhbSwgY29uc3QgY2hhciAq
cG9zdGZpeCwgY2hhciAqKnJldCkKICAgICByZXR1cm4gMDsKIH0KIAotc3RhdGljIGNvbnN0IHN0
cnVjdCB0b2tlbiB7CitzdGF0aWMgY29uc3Qgc3RydWN0IHsKICAgICBjb25zdCBjaGFyICp0b2s7
CiAgICAgUFRZUEUgcGFyYW07CiAgICAgY29uc3QgY2hhciAqcG9zdGZpeDsKZGlmZiAtLWdpdCBh
L3NyYy9saWIva3JiNS9vcy9sb2NhbGFkZHIuYyBiL3NyYy9saWIva3JiNS9vcy9sb2NhbGFkZHIu
YwppbmRleCAyMWJjNzE5Li41ODQ0M2Y2IDEwMDY0NAotLS0gYS9zcmMvbGliL2tyYjUvb3MvbG9j
YWxhZGRyLmMKKysrIGIvc3JjL2xpYi9rcmI1L29zL2xvY2FsYWRkci5jCkBAIC04NjIsNiArODYy
LDkgQEAgZ2V0X2lmcmVxX2FycmF5KGNoYXIgKipidWZwLCBzaXplX3QgKm5wLCBpbnQgcykKICAg
ICBpbnQgbnVtaWZzID0gLTE7CiAjZW5kaWYKIAorICAgICpidWZwID0gTlVMTDsKKyAgICAqbnAg
PSAwOworCiAgICAgLyogQXQgbGVhc3Qgb24gTmV0QlNELCBhbiBpZnJlcSBjYW4gaG9sZCBhbiBJ
UHY0IGFkZHJlc3MsIGJ1dAogICAgICAgIGlzbid0IGJpZyBlbm91Z2ggZm9yIGFuIElQdjYgb3Ig
ZXRoZXJuZXQgYWRkcmVzcy4gIFNvIGFkZCBhCiAgICAgICAgbGl0dGxlIG1vcmUgc3BhY2UuICAq
LwpAQCAtOTM4LDkgKzk0MSw5IEBAIGZvcmVhY2hfbG9jYWxhZGRyICgvKkBudWxsQCovIHZvaWQg
KmRhdGEsCiAjZW5kaWYKIHsKICAgICBzdHJ1Y3QgaWZyZXEgKmlmciwgaWZyZXEsICppZnIyOwot
ICAgIGludCBzLCBjb2RlOworICAgIGludCBzOwogICAgIGNoYXIgKmJ1ZiA9IDA7Ci0gICAgc2l6
ZV90IHNpemUsIG4sIGksIGo7CisgICAgc2l6ZV90IG4sIGksIGo7CiAgICAgaW50IHJldHZhbCA9
IDA7CiAjaWZkZWYgTElOVVhfSVBWNl9IQUNLCiAgICAgc3RydWN0IGxpbnV4X2lwdjZfYWRkcl9s
aXN0ICpsaW51eF9pcHY2X2FkZHJzID0gZ2V0X2xpbnV4X2lwdjZfYWRkcnMgKCkK
--_002_B37989F2852398498001550C29155BE5178BBCA2FRCRPVV9EX3MSXw_
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
_______________________________________________
krbdev mailing list krbdev@mit.edu
https://mailman.mit.edu/mailman/listinfo/krbdev
--_002_B37989F2852398498001550C29155BE5178BBCA2FRCRPVV9EX3MSXw_--
