[19702] in Kerberos_V5_Development
Re: Probable boolean logic error
daemon@ATHENA.MIT.EDU (Robbie Harwood)
Wed Dec 6 11:28:05 2017
From: Robbie Harwood <rharwood@redhat.com>
To: Michael McConville <mmcco@mykolab.com>, krbdev@mit.edu
In-Reply-To: <20171206042807.katpispjvptttpgj@t240>
Date: Wed, 06 Dec 2017 11:27:47 -0500
Message-ID: <jlgtvx3yg70.fsf@redhat.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0865838444531896054=="
Errors-To: krbdev-bounces@mit.edu
--===============0865838444531896054==
Content-Type: multipart/signed; boundary="=-=-=";
micalg=pgp-sha512; protocol="application/pgp-signature"
--=-=-=
Content-Type: text/plain
Michael McConville <mmcco@mykolab.com> writes:
> Hi guys.
>
> The below if condition is obviously always true in its current state.
> It seems that the author meant to use && rather than ||.
>
> Thanks for your time,
> Michael McConville
> University of Utah
>
> diff --git a/src/windows/leashdll/krb5routines.c b/src/windows/leashdll/krb5routines.c
> index 3911720ae..ff5eb4980 100644
> --- a/src/windows/leashdll/krb5routines.c
> +++ b/src/windows/leashdll/krb5routines.c
> @@ -255,7 +255,7 @@ LeashKRB5_renew(void)
> pkrb5_cc_set_flags(ctx, cc, KRB5_TC_NOTICKET);
> #endif
> if (code) {
> - if ( code != KRB5KDC_ERR_ETYPE_NOSUPP ||
> + if ( code != KRB5KDC_ERR_ETYPE_NOSUPP &&
> code != KRB5_KDC_UNREACH)
> Leash_krb5_error(code, "krb5_get_renewed_creds()", 0, &ctx, &cc);
> goto cleanup;
That doesn't seem correct to me. On line 253, we call into
pkrb5_get_renewed_creds(), which is what's being checked by this call -
it's a wrapper around get_valrenewed_creds(), which can return a lot
more than KRB5KDC_ERR_ETYPE_NOSUPP and KRB5_KDC_UNREACH - including
EINVAL, ENOMEM, KRB5_CC_NOTFOUND, to name a few.
Thanks,
--Robbie
--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEA5qc6hnelQjDaHWqJTL5F2qVpEIFAlooGoMACgkQJTL5F2qV
pEI6sw//ZjTvRHn4O3uHlybbssJ9zbbAIlQPX8NAQ8ZChkP6zVjxmGtizqCopcSS
+MHNn4lQlaYActorugOwmEPvM1MLc6hWEdZ2GcxmVgdgeQq0luZ7cTxjj856PwaG
Jd/BmrOn3q3214Y/tdC9i/R1fpdSlClRhN+Ua0Nz342RGsllwyBCXjGKMeg8pNYE
yXvLCRuUikiUveAvf5dW1neOImPfUFk1Px37BxRQxWfWWrYv1Q9IbMs1caUidalo
O9IAFOKr4k7G2Y8/smEWWFqXZbQ6a+1EW9W4Q5Lo4Qr9emu7BdpIIZdijhVc8ugE
95+Cxr60CtFYqkV/k9DbC3BchYNDJPNDhKuPSU9ui0bXcddOA6aq17xb5EWflkYo
RGoC3H7KR2OwE+vSROghXedUPU0cHLTLbuXrGvFxR7KzlZoNvib5+ZcuUdbGfTQ9
cy494vrhtlYkpCdcalfKgH7zNU4aRt5inZI70alB/YP5vqnU70zIM1DUV/rwKL1Q
E59Tr8q15yaAhqAz1+NodIhMfUs8RECRWKYZRjn1BZRBKdF1PzClQUAUeygJoxxB
Av4vwCNQ0gnqqXgG9lV0P/knbfit4CYyTZWo1W9Lno9cEy2WqKQm/YnfHpupZqVV
c6Ev0fjV7gklKrdaK1pWBloKHkD5Ulg8yCy89MW/1WaJAk4QPzQ=
=6hGC
-----END PGP SIGNATURE-----
--=-=-=--
--===============0865838444531896054==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
_______________________________________________
krbdev mailing list krbdev@mit.edu
https://mailman.mit.edu/mailman/listinfo/krbdev
--===============0865838444531896054==--
